Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename joplin empirical restoration analysis to joplin empirical buil… #376

Conversation

Rashmil-1999
Copy link
Contributor

…ding restoration analysis

I think I got almost all the places. Can you please let me know if I have missed anything @navarroc ?

@Rashmil-1999 Rashmil-1999 requested a review from navarroc April 24, 2024 16:50
@Rashmil-1999 Rashmil-1999 self-assigned this Apr 24, 2024
@navarroc
Copy link
Member

navarroc commented Apr 24, 2024

analyses.md needs to be updated. Also analyses.md refers to the notebook you renamed but you need to update the link inside analyses.md.

20. [Joplin empirical building restoration](analyses/jopling_empirical_building_restoration)

That will allow it to find the markdown file you renamed.

@Rashmil-1999
Copy link
Contributor Author

I just updated that file

Copy link
Contributor

@ylyangtw ylyangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much Rashmil! All look good. Could you add changelog? :P

Copy link
Member

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog

@longshuicy longshuicy merged commit 0099945 into develop Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update notebooks that include Joplin Empirical Restoration analysis
4 participants